Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flow trigger docs #5561

Closed
wants to merge 7 commits into from
Closed

fix: flow trigger docs #5561

wants to merge 7 commits into from

Conversation

anna-geller
Copy link
Member

No description provided.

@anna-geller
Copy link
Member Author

@fhussonnois do you remember how you made the flow outputs available to downstream flows via {{ trigger.outputs.flow_output_id }}? this should work but currently tests fail when using this syntax, could you check and fix my branch so we can merge the fix to the Flow trigger docs + tests?

@fhussonnois
Copy link
Member

The expression {{ trigger.outputs.flow_output_id }} is correct, but you should not modify the flows under test/resources/flows/valids. We have assertions that can be based on task-id, return values, output names, etc. So, if you update the flows, we have also to rewrite the tests

@anna-geller
Copy link
Member Author

Got it, can you help by fixing the tests and adjusting the flow and pushing to this branch? Long term, we want to deprecate the option to access outputs of upstream flows by using {{ outputs.task_id_output_name }} as it's dangerous in terms of permissions (using outputs not exposed via flow outputs) + confusing (this syntax is for the current flow only)

@anna-geller
Copy link
Member Author

anyway, I'll let you fix the outdated tests whenever you want 👍 for now, PR to fix docs #5592

@tchiotludo tchiotludo deleted the fix/flow_trigger_docs branch October 25, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants